Do not send Heap Stats to the LSP log #3111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It interferes with the ability of lsp-test to detect timeouts in e.g. benchmarks The assumption is that logging them to stderr serves the purpose they were designed for.
|
Would it make sense to just disable the client logs when doing tests or benchmarks? |
It's easy to do and I don't have a strong opinion |
pepeiborra
force-pushed
the
silence-heap-stats-lsp
branch
from
9226cb8 to
43586ab
Compare
pepeiborra
force-pushed
the
silence-heap-stats-lsp
branch
from
43586ab to
eb32021
Compare
kokobd
approved these changes
Aug 18, 2022
This PR doesn't remove the log from stderr, only from the LSP stream. We only started emitting those around 3 months ago so I doubt any users depend on them. |
|
I just think it makes our logging less consistent, which is confusing in future. But 🤷 |
sloorush
pushed a commit
to sloorush/haskell-language-server
that referenced
this pull request
Sep 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It interferes with the ability of lsp-test to detect timeouts in e.g. benchmarks
The assumption is that logging them to stderr serves the purpose they
were designed for.