Cleanup GHC macros (because min version is 8.8.4) #3281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andys8
force-pushed
the
remove-865-macros
branch
2 times, most recently
from
7501e5d to
8d6ffce
Compare
andys8
requested review from
kokobd,
Anton-Latukha,
Ailrun and
michaelpj
as code owners
andys8
force-pushed
the
remove-865-macros
branch
from
8d6ffce to
2255740
Compare
|
We're going to drop 8.8 also, do you want to wait for that before tidying up? I guess this is good regardless! |
|
Should we drop related hie-compat also? |
Yeah, I was asking about dropping 8.8 support but since 8.6 and 8.8 are split in several PRs, I would also split tidying up the macros. First getting rid of 8.6, then getting rid of 8.8. |
andys8
force-pushed
the
remove-865-macros
branch
from
422a5f7 to
9f29d85
Compare
Thanks for pointing this out. Done with 9f29d85. |
isovector
approved these changes
Oct 11, 2022
michaelpj
reviewed
Oct 11, 2022
michaelpj
reviewed
Oct 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #3101 the minimum supported GHC version is
8.8.4. This allows us to drop (or modify all conditional pragmas) targetting lower ghc versions or remove them since we already know GHC is min 8.8.4.Changes
I grepped through the codebase with
"#if.*MIN_VERSION_ghc\(8,8"and"__GLASGOW_HASKELL__.*808"and code that can now be removed.Review