Cleanup Development.IDE.CodeAction #3360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
santiweight
force-pushed
the
cleanup-plugin-codeaction
branch
from
82cf824 to
3a835ad
Compare
santiweight
force-pushed
the
cleanup-plugin-codeaction
branch
from
3a835ad to
975ef7a
Compare
michaelpj
approved these changes
Nov 22, 2022
michaelpj
reviewed
Nov 23, 2022
| , TextEdit _range (if parenthise then addParens name' else name') | ||
| ) | ||
| case T.uncons name of | ||
| Nothing -> error "impossible: empty name provided by ghc" |
There was a problem hiding this comment.
To be clear, these are an improvement in that they give clearer errors, but they will still crash HLS unrecoverably. We really, really want to avoid error and friends also. But fixing them properly would require more refactoring.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract a couple of modules from the massive CodeAction file...
Intended for commit-by-commit review