Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GHC 9.4: Compute the source hash before the preprocessor #3415

Merged
merged 4 commits into from
Dec 21, 2022

Conversation

wz1000
Copy link
Collaborator

@wz1000 wz1000 commented Dec 20, 2022

Compute the source hash before the preprocessor because that is
how GHC does it.

This reduces spurious rebuilds of modules using CPP on GHC 9.4

@wz1000 wz1000 requested a review from pepeiborra as a code owner December 20, 2022 17:34
Copy link
Collaborator

@fendor fendor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@wz1000 wz1000 force-pushed the wip/fix-9.4-hash branch 2 times, most recently from 4cefb2b to 206eb47 Compare December 21, 2022 09:12
how GHC does it.

This reduces spurious rebuilds of modules using CPP on GHC 9.4
@wz1000 wz1000 added the merge me Label to trigger pull request merge label Dec 21, 2022
@mergify mergify bot merged commit 881d23b into master Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge me Label to trigger pull request merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants