Remove extra call to newHscEnvEqWithImportPaths #3676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We also update the |
|
Worth a comment explaining what's going on? |
|
|
|
put it in the code! |
nlander
commented
Jun 30, 2023
| @@ -799,7 +799,12 @@ ghcSessionDepsDefinition fullModSummary GhcSessionDepsConfig{..} env file = do | |||
| #endif | |||
| session' <- liftIO $ mergeEnvs hsc moduleNode inLoadOrder depSessions | |||
|
|
|||
| Just <$> liftIO (newHscEnvEqWithImportPaths (envImportPaths env) session' []) | |||
| -- Here we avoid a call to to `newHscEnvEqWithImportPaths`, which creates a new | |||
There was a problem hiding this comment.
@michaelpj Does this sufficiently explain what's going on here? Is there anything we should add?
There was a problem hiding this comment.
I would say ask yourself:
- If I was reading this for the first time, would I know what is going on and why?
- Has this captured the knowledge that I gained in order to make the fix?
nlander
force-pushed
the
remove-extra-hscenveq
branch
from
ff6d39e to
222b050
Compare
michaelpj
approved these changes
Jun 30, 2023
| @@ -799,7 +799,12 @@ ghcSessionDepsDefinition fullModSummary GhcSessionDepsConfig{..} env file = do | |||
| #endif | |||
| session' <- liftIO $ mergeEnvs hsc moduleNode inLoadOrder depSessions | |||
|
|
|||
| Just <$> liftIO (newHscEnvEqWithImportPaths (envImportPaths env) session' []) | |||
| -- Here we avoid a call to to `newHscEnvEqWithImportPaths`, which creates a new | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submitting this at the request of @wz1000
Instead of calling
newHscEnvEqWithImportPathsagain inghcSessionDepsDefinition, we only generate a newUniquefor theHscEnvEqand update theenvUniquefield.