Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump ormolu to 0.1.3.0 #422

Merged
merged 2 commits into from
Oct 5, 2020
Merged

Bump ormolu to 0.1.3.0 #422

merged 2 commits into from
Oct 5, 2020

Conversation

AlistairB
Copy link
Contributor

I just pinned it with extra-deps in all cases.

Alternatively 0.1.3.0 appears in nightly-2020-09-22 and should appear in lts-16.16 in a few days. So I could instead bump ghc 8.8.3 and up to use the updated resolvers (and I guess remove other extra deps that no longer need to be pinned)?

@lukel97
Copy link
Collaborator

lukel97 commented Oct 3, 2020

@AlistairB if there's a newer LTS snapshot that includes it please swap to it, the fewer extra-deps the better!

And unpin dependencies that were pinned to a matching version in the
new resolver.
@AlistairB
Copy link
Contributor Author

@bubba No problem. I updated 8.8.4 and 8.10.2 to the latest lts and nightly respectively. I unpinned dependencies that have an exact version match with the resolver. Others seem like they may be able to be unpinned and be updated to new minor versions (ie. I suspect extra-1.7.3 could be updated to use latest of extra-1.7.8), but I left those pinned as is.

Copy link
Collaborator

@lukel97 lukel97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ndmitchell
Copy link
Collaborator

As a general rule, any dependency can be upgraded as far as you like (even major bumps) unless it's got a comment explicitly saying otherwise.

@lukel97 lukel97 merged commit 93a3b53 into haskell:master Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants