-
-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Miscellaneous fixes #672
Miscellaneous fixes #672
Conversation
agree, maybe |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the fixes, i'll wait for @isovector review for tactic plugin changes
And tactics plugin needs a LICENSE file :) |
what about |
Agree, editors would treat these files as yaml properly. |
@berberman nice, do you mind include that file renaming in this pr or do you think is better to left it for a new one? |
The readme should be updated too (if we change file names): haskell-language-server/README.md Line 688 in 3717653
|
I prefer including it in this PR, just as the title said XD |
We shoud do the same thing to ghcide :) |
I think tactic plugin cabal config values was set thinking it would be in a separate repo so i think we could remove it until that move is actually done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks (again 🙂 )!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Retrie plugin is missing in hie.yaml.cbl, and tactics plugin's cabal file contains some invalid links.
BTW, I don't think
.cbl
is a good filename extension, since github would consider it as a COBOL source file :P