Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miscellaneous fixes #672

Merged
merged 4 commits into from
Dec 14, 2020
Merged

Miscellaneous fixes #672

merged 4 commits into from
Dec 14, 2020

Conversation

berberman
Copy link
Collaborator

Retrie plugin is missing in hie.yaml.cbl, and tactics plugin's cabal file contains some invalid links.
BTW, I don't think .cbl is a good filename extension, since github would consider it as a COBOL source file :P

@jneira
Copy link
Member

jneira commented Dec 14, 2020

BTW, I don't think .cbl is a good filename extension, since github would consider it as a COBOL source file :P

agree, maybe .cabal would be better, but it is used for cabal package config so 🤷

@jneira jneira requested a review from isovector December 14, 2020 06:30
Copy link
Member

@jneira jneira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fixes, i'll wait for @isovector review for tactic plugin changes

@berberman
Copy link
Collaborator Author

And tactics plugin needs a LICENSE file :)

@jneira
Copy link
Member

jneira commented Dec 14, 2020

what about stack.hie.yaml and cabal.hie.yaml (or something alike)?

@berberman
Copy link
Collaborator Author

Agree, editors would treat these files as yaml properly.

@jneira
Copy link
Member

jneira commented Dec 14, 2020

@berberman nice, do you mind include that file renaming in this pr or do you think is better to left it for a new one?

@jneira
Copy link
Member

jneira commented Dec 14, 2020

The readme should be updated too (if we change file names):

$ cp hie.yaml.cbl hie.yaml

@berberman
Copy link
Collaborator Author

berberman commented Dec 14, 2020

@berberman nice, do you mind include that file renaming in this pr or do you think is better to left it for a new one?

I prefer including it in this PR, just as the title said XD

@berberman
Copy link
Collaborator Author

We shoud do the same thing to ghcide :)

@jneira
Copy link
Member

jneira commented Dec 14, 2020

I think tactic plugin cabal config values was set thinking it would be in a separate repo so i think we could remove it until that move is actually done.
So i am gonna merge it to include in the next release, we always could revert bab10e8
//cc @isovector

Copy link
Member

@jneira jneira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks (again 🙂 )!

Copy link
Member

@Ailrun Ailrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@berberman berberman marked this pull request as ready for review December 14, 2020 13:45
@berberman berberman requested a review from jneira December 14, 2020 13:52
@jneira jneira merged commit 60f811c into haskell:master Dec 14, 2020
@berberman berberman deleted the patch-misc branch December 15, 2020 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants