Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use haskell-interactive-switch in process-load #1140

Merged
merged 1 commit into from
Feb 7, 2016

Conversation

bergey
Copy link
Contributor

@bergey bergey commented Feb 7, 2016

This sets a variable with the source buffer so we can switch back.

This is pretty bizzare, though. Both before and after this commit,
haskell-session-interactive-buffer switches to the buffer if it's
newly created, but if the buffer already exists, just returns the buffer
without visiting. This function shouldn't switch, and callers
should decide if they want to switch.

closes #955

This sets a variable with the source buffer so we can switch back.

This is pretty bizzare, though.  Both before and after this commit,
`haskell-session-interactive-buffer` switches to the buffer if it's
newly created, but if the buffer already exists, just returns the buffer
without visiting.  This function shouldn't switch, and callers
should decide if they want to switch.

closes haskell#955
@bergey
Copy link
Contributor Author

bergey commented Feb 7, 2016

If you merge this now, I can open a new issue about checking which uses of haskell-session-interactive-buffer rely on the undocumented switching behavior, and refactoring to fix them. I'm not sure when I'll have time to actually do that searching.

@gracjan gracjan changed the title use haskell-interactive-switch in process-load Use haskell-interactive-switch in process-load Feb 7, 2016
gracjan added a commit that referenced this pull request Feb 7, 2016
Use `haskell-interactive-switch` in process-load
@gracjan gracjan merged commit 7972207 into haskell:master Feb 7, 2016
@gracjan
Copy link
Contributor

gracjan commented Feb 7, 2016

Thanks. The switching behavior is one of the more confusing parts when working with haskell-interactive. Please try to sort this out when you have time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

haskell-process-load-or-reload and haskell-interactive-switch-back
2 participants