-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge hi2 #502
Conversation
@purcell, @chrisdone, I've been using this branch for a while and I see major improvement over old code. I think we should merge what is here. Opinions? |
👍 |
@gracjan Please go ahead and merge this if you're satisfied it's ready. |
I'll do a little more testing by using.
|
99ee369
to
e4c511e
Compare
Maybe it would make sense to only parse when point changes to another line? |
For example add to post command-hook:
|
I've fixed this already in wip/hi2 branch. It parses after a timer right
now and is not getting in the way any more.
|
A timer is rather arbitrary. The method I described will only parse when necessary. |
Or use both... |
And times is also good because it moves expensive computation out of interactive loop. |
There are not many problematic cases where a command changes the buffer but leaves the current line the same. The only one I can think of is changing or editing a keyword as the first token on the current line. This will change the indentations. That could be easily checked for. |
Conflicts: haskell-indentation.el
Doc string was treated as its value.
Showing overlays calculated indentation positions and that is a costly function that should not can called at every cursor movement.
No description provided.