Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark various turn-on-haskell-* functions obsolete #774

Merged
merged 1 commit into from
Jul 24, 2015
Merged

Mark various turn-on-haskell-* functions obsolete #774

merged 1 commit into from
Jul 24, 2015

Conversation

ankhers
Copy link
Contributor

@ankhers ankhers commented Jul 23, 2015

This is still a work in progress, I just want some feedback on what I have done, and what I still need to do.

  1. Does it make sense to convert turn-on-haskell-font-lock into a minor mode?
  2. I'm not really sure what to do with turn-on-haskell-unicode-input-method. It honestly seems fine as it is.
  3. I plan on converting turn-on-haskell-indent into a minor mode similar to haskell-indentation-mode.

Fix #771

@ankhers
Copy link
Contributor Author

ankhers commented Jul 23, 2015

I'm not entirely sure why the tests are failing for my branch. I didn't touch the code that it is complaining about. Any insights would be great.

In toplevel form:
haskell-sort-imports.el:128:1:Error: the function `copy-list' is not known to be defined.
make: *** [haskell-sort-imports.elc] Error 1

@gracjan
Copy link
Contributor

gracjan commented Jul 23, 2015

Tests are failing due to something else, do not worry about this.

Answers:

  1. font-lock-mode is already an Emacs minor mode (enabled by default), so
    no need to do anything there.
    1a. turn-on-haskell-font-lock used to be used in ghc-mod (other package) so
    we need to keep it for a while as it is.
  2. unicode input is good as it is, no need to change that one.
  3. haskell-simple-indent won't be developed anymore, we should concentrate
    on haskell-indentation as that is where the future lies.

@gracjan
Copy link
Contributor

gracjan commented Jul 23, 2015

I've fixed copy-list problem, just rebase over current master and you should be fine.

@ankhers
Copy link
Contributor Author

ankhers commented Jul 24, 2015

I feel like that rebase didn't do what I wanted it to. Let me know if you want me to start a new branch for this.

@gracjan
Copy link
Contributor

gracjan commented Jul 24, 2015

You should have just one commit on your branch. A clever use of git reset --hard, git cherry-pick and git push upstream +debt/mark_turn-on_functions_obsolete should do the trick.

@ankhers ankhers changed the title [WIP] mark various turn-on-haskell-* functions obsolete [G2M] mark various turn-on-haskell-* functions obsolete Jul 24, 2015
@ankhers
Copy link
Contributor Author

ankhers commented Jul 24, 2015

In that case, I think this is ready to be merged.

@gracjan gracjan changed the title [G2M] mark various turn-on-haskell-* functions obsolete Mark various turn-on-haskell-* functions obsolete Jul 24, 2015
gracjan added a commit that referenced this pull request Jul 24, 2015
…lete

Mark various turn-on-haskell-* functions obsolete
@gracjan gracjan merged commit 5197b6b into haskell:master Jul 24, 2015
@gracjan
Copy link
Contributor

gracjan commented Jul 24, 2015

@ankhers: Good stuff! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants