Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prohibit unbuildable Windows configurations due to GHC bugs wrt TemplateHaskell and C interaction #404

Merged
merged 2 commits into from
Jan 12, 2022

Conversation

Bodigrim
Copy link
Contributor

@Bodigrim Bodigrim commented Jan 8, 2022

Closes #385.
@RyanGlScott, could you please take a look?

text.cabal Outdated Show resolved Hide resolved
Copy link
Member

@RyanGlScott RyanGlScott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm no longer able to construct a build plan with GHC 8.2.2, so as far as I'm concerned, this fixes the issue for me. Thanks!

@Bodigrim
Copy link
Contributor Author

Bodigrim commented Jan 9, 2022

@Boarders @Lysxia this is ready for review.

@Bodigrim Bodigrim merged commit 40a48d6 into haskell:master Jan 12, 2022
@Bodigrim Bodigrim deleted the windows-th-c-linking branch January 12, 2022 01:01
@RyanGlScott
Copy link
Member

Is it possible to revise text-2.0 on Hackage to include these changes? Even after the release of text-2.0.1 (which includes this fix), cabal will still include text-2.0 in build plans involving GHC 8.2 on Windows, which breaks the build. See here for an example.

@Bodigrim
Copy link
Contributor Author

I think Hackage revisions cannot add conditionals, so the only option is to deprecate text-2.0 altogether, which I do not feel fully justified at this point.

@RyanGlScott
Copy link
Member

I think Hackage revisions cannot add conditionals

Darn, that's really unfortunate. Is there a hackage-server issue tracking this somewhere?

In the meantime, I suppose I'll just have to exclude GHC 8.2 from CI on Windows.

RyanGlScott added a commit to RyanGlScott/text-show that referenced this pull request Jul 28, 2022
See the discussion starting at
haskell/text#404 (comment)
for more context.
RyanGlScott added a commit to RyanGlScott/text-show-instances that referenced this pull request Jul 28, 2022
See the discussion starting at
haskell/text#404 (comment)
for more context.
@phadej
Copy link
Contributor

phadej commented Jul 28, 2022

I think Hackage revisions cannot add conditionals

Darn, that's really unfortunate. Is there a hackage-server issue tracking this somewhere?

I cannot find one, but i'm pretty sure there was sometehing either on hackage-server or hackage-cli issue trackers. I was looking into that 2-3 years ago (it's not trivial, but not impossible either).

(relatedly, if hackage-trustees/hackage-cli#9 lib is split out into standalone lib, so it's actually shared between hackage-server and hackage-cli, might increase people motivation to contribute things. AFAIK those are also the only revision related tests existing - which is not that great)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

text-2.0 candidate release
4 participants