Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add inspection tests to vector #389

Merged
merged 3 commits into from
May 24, 2021
Merged

Conversation

Shimuuar
Copy link
Contributor

At this point its mostly skeleton with single test. At the moment I'm a bit at loss what to add. Maybe copy tests from text?

Tests are placed into separate test suite because common test suite is built with both -O0 and -O2 and former will break fusion.

@Bodigrim
Copy link
Contributor

Fusion tests in text were generated using my fork of inspection-testing: https://github.com/Bodigrim/inspection-testing/tree/6b99b613b30fc2216f391db08b857a54352e4f48/examples/text-api
It should be possible to adapt the generator to vector.

Inspection testing relies on GHC plugins, and requires GHC 8.0.

@Shimuuar
Copy link
Contributor Author

@Bodigrim thanks for the input

Shimuuar added 3 commits May 24, 2021 22:31
Inspection tests placed in separate test suite since vector-tests are built with
both -O0 and -O2 optimization level and O-0 will break inspection tests.
It's just simplest function possible.
@Shimuuar Shimuuar marked this pull request as ready for review May 24, 2021 20:31
@Shimuuar
Copy link
Contributor Author

I want to have working inspection tests for iso-deriving PR (#378) so I'm merging this one. Proper tests should be left for another PR

@Shimuuar Shimuuar merged commit a735abb into haskell:master May 24, 2021
@Shimuuar Shimuuar deleted the inspection branch May 24, 2021 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants