Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement spanR & breakR #476

Merged
merged 3 commits into from
Jan 17, 2024
Merged

Implement spanR & breakR #476

merged 3 commits into from
Jan 17, 2024

Conversation

Shimuuar
Copy link
Contributor

They follow same convention as Data.Sequence.spanR/breakR. Fixes #172

I also notices that we don't run tests with unsafe and internal range checks on. We should do that in part because we should check that such configuration actually works and it may save us in the future.

I noticed that we don't run build and test configuration with checks enabled on
CI. We should exercise it and it may save us at some point.
Copy link
Contributor

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Shimuuar Shimuuar merged commit 24426ad into haskell:master Jan 17, 2024
22 checks passed
@Shimuuar Shimuuar deleted the spanR branch January 22, 2024 07:53
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request Jan 29, 2025
# Changes in version 0.13.2.0

 * Strict boxed vector `Data.Vector.Strict` and `Data.Vector.Strict.Mutable` is
   added (#488). it ensures that all values in the vector are evaluated to WHNF.
 * `DoNotUnboxStrict`, `DoNotUnboxLazy`, and `DoNotUnboxNormalForm` wrapper are
   added for defining unbox instances for types that contain not unboxable fields.
   [#503](haskell/vector#506),
   [#508](haskell/vector#508)
 * `spanR` and `breakR` were added [#476](haskell/vector#476).
   They allow parsing vector from the right.
 * We had some improvements on `*.Mutable.{next,prev}Permutation{,By}`
   [#498](haskell/vector#498):
   * Add `*.Mutable.prevPermutation{,By}` and `*.Mutable.nextPermutationBy`
   * Improve time performance. We may now expect good specialization supported by inlining.
     The implementation has also been algorithmically updated: in the previous implementation
     the full enumeration of all the permutations of `[1..n]` took Omega(n*n!), but it now takes O(n!).
   * Add tests for `{next,prev}Permutation`
   * Add benchmarks for `{next,prev}Permutation`
 * Cabal >= 3.0 is now required for building package (#481).
 * `vector:benchmarks-O2` public sublibrary containing benchmarks is added (#481).
 * Type family `Mutable` provides instances for arrays from `primitive`.
 * Various documentation improvements.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is there an efficient way to break/span/findIndex from the right end?
2 participants