Fix #113 #114
Merged
Fix #113 #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @filips123, I had forgotten about this PR completely, my apologies. Is there anything to be improved in particular (with regards to code style and tests)? Having had a brief look over, it seems good to me 👍 |
|
It is finished, but code style could maybe be better. What do you think? |
Closed
|
Personally, didn't see any major issues with code style 👍 thanks again for your hard work, @filips123, much appreciated 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It fixes #113.
It adds two separated methods for parsers
parseFile()andparseString(). Both then call protected methodparse()to complete parsing and handle errors.Fix for PHP tags in strings still need to be added. It should remove only first and last line if there are(fixed in 22b60dc)<?php,<?or?>. If possible, other solution should be #113 (comment).How can I make this?
This code should work, but maybe there should be better code style and tests.