Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept pre-mounted FUSE descriptor #121

Merged
merged 2 commits into from
Nov 19, 2019
Merged

Accept pre-mounted FUSE descriptor #121

merged 2 commits into from
Nov 19, 2019

Conversation

fdegros
Copy link
Collaborator

@fdegros fdegros commented Nov 18, 2019

This allows rar2fs to accept a mount point in the form of /dev/fd/xxxx where xxxx is an integer, and pass it to the underlying libfuse.

This is useful if the underlying libfuse itself can deal with pre-mounted FUSE descriptors, as does the patched libfuse used in ChromiumOS.

Copy link
Owner

@hasse69 hasse69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general looks good, just some minor things to address.

src/rar2fs.c Outdated Show resolved Hide resolved
src/rar2fs.c Outdated Show resolved Hide resolved
@hasse69
Copy link
Owner

hasse69 commented Nov 19, 2019

Next time I think you should amend your commits so that we do not end up with multiple commit messages since that makes it harder to squash them nicely. Or possibly, I have misunderstood something :)

@fdegros
Copy link
Collaborator Author

fdegros commented Nov 19, 2019

I can't see any way for me to merge this pull request.

There is a green box with:

Changes approved
This branch has no conflicts with the base branch
Only those with write access to this repository can merge pull requests.

But no Merge Pull Request green button as described in GitHub - Contributing to a Project.

Can you see this button and merge the pull request?

@hasse69 hasse69 merged commit b8b8ddd into hasse69:master Nov 19, 2019
@fdegros
Copy link
Collaborator Author

fdegros commented Nov 19, 2019

Thanks

@fdegros fdegros deleted the pass-fuse-file-descriptor branch November 19, 2019 22:32
@hasse69
Copy link
Owner

hasse69 commented Nov 19, 2019

No problem. But as you can see the two squashed commits does not turn out so nice in the commit message. But squashing them was the most natural thing to do here. If you would have amended your second commit towards the first I believe it would have looked better. But really, no big deal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants