Fix building with libc++. #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hasse69
requested changes
Nov 19, 2019
|
It is an interesting observation that this is not working on some platforms, in fact this is how it looked a long time ago. For some reason, that I cannot recall right now, it was changed. Agree it is not something to recommend. Now it seems to work fine so please address my comment and we can merge this. |
Do not hardcode stdc++ when linking. Rather, use C++ compiler as the linker driver which will choose correct C++ library for linking. Chrome OS bug: https://bugs.chromium.org/p/chromium/issues/detail?id=1026266
|
Updated, ptal. |
|
Thanks for the contribution. Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not hardcode stdc++ when linking. Rather, use C++
compiler as the linker driver which will choose correct
C++ library for linking.
Chrome OS bug:
https://bugs.chromium.org/p/chromium/issues/detail?id=1026266