fix: correct ifdef check for VER_UNKNOWN #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR. An oversight from my side obviously. |
fastcat
force-pushed
the
fix/debian-unrar-src-5.6.6
branch
from
b47fbf4 to
a583598
Compare
|
Fixed (for reference, it's from using https://www.conventionalcommits.org/ elsewhere) |
|
Can you please make it uppercase too, Correct vs correct, or change correct to "Fix", and you get the best of both worlds :) |
|
Also add yourself to AUTHORS if you like. |
fastcat
force-pushed
the
fix/debian-unrar-src-5.6.6
branch
from
a583598 to
76590bd
Compare
|
Done 👍 |
|
Merged. Thanks again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to build
rar2fsfor Debian, and thus using the version of the unrar source (and libraries) available there, I ran into a build error aroundVER_UNKNOWN.That
#definefirst showed up in 5.7.1, and is unavailable in 5.6.6, which reportsRARVER_MINOR = 61