Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Alpine 3.21 (NodeJS 22) #627

Merged
merged 1 commit into from
Feb 16, 2025
Merged

Update to Alpine 3.21 (NodeJS 22) #627

merged 1 commit into from
Feb 16, 2025

Conversation

frenck
Copy link
Member

@frenck frenck commented Feb 16, 2025

Proposed Changes

SSIA

Summary by CodeRabbit

  • Chores
    • Upgraded the platform's Alpine Linux template from version 3.19 to 3.21.
    • Updated the base image to a newer version.
    • Revised multiple dependency versions (e.g., git, Python, OpenSSL, nginx) for enhanced consistency.
    • Added a new dependency, yarn.
    • Standardized build configurations across different architectures.

@frenck frenck added the maintenance Generic maintenance tasks. label Feb 16, 2025
Copy link

coderabbitai bot commented Feb 16, 2025

Walkthrough

The pull request updates dependency and base image configurations. In the Renovate configuration, the Alpine package template is updated from version 3.19 to 3.21. In the proxy-manager files, the base image has been changed from a Node.js-specific image (ghcr.io/hassio-addons/base-nodejs:0.2.2) to a general base image (ghcr.io/hassio-addons/base:17.2.1), and multiple package versions in the Dockerfile have been upgraded while a new package (yarn) has been added. The build YAML file reflects the base image update across various architectures.

Changes

Files Change Summary
.github/renovate.json Updated depNameTemplate for Dockerfile matching from alpine_3_19/{{package}} to alpine_3_21/{{package}}.
proxy-manager/{Dockerfile, build.yaml} Updated base image from ghcr.io/hassio-addons/base-nodejs:0.2.2 to ghcr.io/hassio-addons/base:17.2.1; Dockerfile includes multiple package version upgrades (e.g., git, libffi-dev, openssl-dev, python3-dev, certbot, libcap, nginx, py3-pip, python3) and adds a new package yarn.

Suggested labels

dependencies, no-stale

Poem

Oh, I’m a rabbit with a curious code hop,
Leaping through changes that never stop.
Alpine’s version now shines so bright,
And packages update in cheerful light.
With every upgrade my whiskers twitch in glee,
Hopping to a future as snappy as can be!
🐇🌟


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d47cfdd and d03f316.

📒 Files selected for processing (3)
  • .github/renovate.json (1 hunks)
  • proxy-manager/Dockerfile (2 hunks)
  • proxy-manager/build.yaml (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • proxy-manager/build.yaml
⏰ Context from checks skipped due to timeout of 90000ms (6)
  • GitHub Check: workflows / Build armv7
  • GitHub Check: workflows / Build amd64
  • GitHub Check: workflows / Build aarch64
  • GitHub Check: workflows / Build armv7
  • GitHub Check: workflows / Build amd64
  • GitHub Check: workflows / Build aarch64
🔇 Additional comments (5)
.github/renovate.json (1)

28-28: Update Alpine Linux Version in Dependency Template.

The depNameTemplate has been updated from "alpine_3_19/{{package}}" to "alpine_3_21/{{package}}", which correctly reflects the upgrade to Alpine 3.21. Please verify that this change is consistent with the updated Alpine version references in other parts of the repository (e.g., in the Dockerfile and build configuration files).

proxy-manager/Dockerfile (4)

1-1: Update Base Image Configuration.

The ARG BUILD_FROM directive has been updated to use ghcr.io/hassio-addons/base:17.2.1 instead of the previous NodeJS-specific image. This change aligns with the upgrade objectives and ensures a more generalized base image is used for Alpine 3.21 and NodeJS 22.


21-23: Update Build Dependencies Versions: git, libffi-dev, and openssl-dev.

The versions for git (2.47.2-r0), libffi-dev (3.4.6-r0), and openssl-dev (3.3.3-r0) have been updated. These updates are essential to maintain compatibility with the new Alpine base image.


25-25: Update Python Development Package.

The python3-dev package has been revised to 3.12.9-r0, aligning it with the updated Python version expectations. This is a straightforward update that should support subsequent build processes.


29-37: Update Runtime Dependencies and Add Yarn.

The runtime dependencies have several version updates:

  • certbot is updated to 3.0.1-r0
  • libcap is updated to 2.71-r0
  • nginx-mod-stream is updated to 1.26.2-r4
  • nginx is updated to 1.26.2-r4
  • openssl is updated to 3.3.3-r0
  • py3-pip is updated to 24.3.1-r0
  • python3 is updated to 3.12.9-r0

Furthermore, a new package yarn (1.22.22-r1) has been added.

These changes collectively ensure that the dependency versions are current and compatible with Alpine 3.21 and NodeJS 22. Please verify that all these versions meet your application’s requirements and do not introduce incompatibilities.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@frenck frenck merged commit 3accb4f into main Feb 16, 2025
22 checks passed
@frenck frenck deleted the frenck-2025-0095 branch February 16, 2025 22:29
@github-actions github-actions bot locked and limited conversation to collaborators Feb 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
maintenance Generic maintenance tasks.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant