Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🪟 Set window title in bash prompt #434

Merged
merged 1 commit into from
Nov 1, 2022

Conversation

scop
Copy link
Contributor

@scop scop commented Sep 9, 2022

Proposed Changes

With zsh, the window title is set to display the user, host, and path. This makes it happen for bash too, using the same format as it's with zsh.

The TERM cases where this is done come from Ubuntu 20.04 and CentOS 7 combined. (CentOS sets the title via $PROMPT_COMMAND, not $PS1 though.)

Related Issues

None that I know of.

@scop
Copy link
Contributor Author

scop commented Sep 18, 2022

Rebased.

@github-actions
Copy link

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions.

@github-actions github-actions bot added the stale There has not been activity on this issue or PR for quite some time. label Oct 19, 2022
@scop scop force-pushed the bash-window-title branch from c1538b3 to a2172a3 Compare October 19, 2022 17:49
@scop
Copy link
Contributor Author

scop commented Oct 19, 2022

Rebased.

MarkdownLint CI failure seems unrelated, this doesn't touch any markdown files.

I don't have rights to modify the PR labels, so it seems I can't do anything about the other CI failure either, nor remove the stale label.

Anything more I can do to get this moving forward?

@tjorim tjorim added enhancement Enhancement of the code, not introducing new features. and removed stale There has not been activity on this issue or PR for quite some time. labels Oct 19, 2022
Mimics what it's set to in zsh.
@frenck frenck force-pushed the bash-window-title branch from a2172a3 to 382776d Compare November 1, 2022 11:58
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @scop 👍

@frenck frenck changed the title Set window title in bash prompt 🪟 Set window title in bash prompt Nov 1, 2022
@frenck frenck merged commit e64c423 into hassio-addons:main Nov 1, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Nov 3, 2022
@scop scop deleted the bash-window-title branch November 4, 2022 14:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Enhancement of the code, not introducing new features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants