-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reformat docs about read-only Web-UI #464
Reformat docs about read-only Web-UI #464
Conversation
WalkthroughThe Tailscale add-on documentation has been updated to improve clarity regarding configuration options available via the web interface. A highlighted block note has been added to explain that these options are read-only on the web UI and that any changes will be lost on add-on restart. Additionally, the earlier note has been removed from its previous location to reduce confusion. The overall documentation structure remains unchanged. Changes
Suggested labels
Suggested reviewers
Poem
Tip 🌐 Web search-backed reviews and chat
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
tailscale/DOCS.md (1)
81-86
: Refine Note Block Formatting for Clarity and ConsistencyThe updated note block clearly fulfills the PR’s objective by emphasizing that configuration options available via the Web UI are read-only. I recommend a couple of minor stylistic improvements for better readability and consistency:
- Hyphenate "read-only": Replace “read only” with “read-only” to match standard terminology.
- Streamline the causal clause: Remove the comma before “because” (in line 84) to ensure a smoother, more direct explanation.
For example, you could update the note block to:
🧰 Tools
🪛 LanguageTool
[formatting] ~84-~84: If the ‘because’ clause is essential to the meaning, do not use a comma before the clause.
Context: ...u can't > change them through the Web UI, because all the changes made there would be > l...(COMMA_BEFORE_BECAUSE)
[typographical] ~84-~84: Consider adding a comma.
Context: ...the Web UI, because all the changes made there would be > lost when the add-on is rest...(IF_THERE_COMMA)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
tailscale/DOCS.md
(1 hunks)
🧰 Additional context used
🪛 LanguageTool
tailscale/DOCS.md
[formatting] ~84-~84: If the ‘because’ clause is essential to the meaning, do not use a comma before the clause.
Context: ...u can't > change them through the Web UI, because all the changes made there would be > l...
(COMMA_BEFORE_BECAUSE)
[typographical] ~84-~84: Consider adding a comma.
Context: ...the Web UI, because all the changes made there would be > lost when the add-on is rest...
(IF_THERE_COMMA)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @lmagyar 👍
../Frenck
Proposed Changes
Just follows the formatting style of #463
Related Issues
Summary by CodeRabbit