Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to hassio-addons/base:17.1.4 #346

Closed

Conversation

Arturkfmnn
Copy link

@Arturkfmnn Arturkfmnn commented Feb 15, 2025

Fix musl dependency 1.2.5-r8 -> r9 for alpine 3.21
Upgrade packages to align with alpine 3.21 repository
Upgrade wireguard-go to the latest commit to avoid golang.org/x/net/internal/socket: invalid reference to syscall.recvmsg message during build with go 1.23

Proposed Changes

I just saw that the migration to v17 failed. With the changes in the commit it should succeed again. The image build was successful with linux/arm/v7, linux/arm64/v8, linux/arm/v6 and linux/amd64

Related Issues

#221

Summary by CodeRabbit

  • Chores
    • Upgraded the base system images and dependency versions.
    • Enhanced the build process for improved stability, security, and multi-platform compatibility.
    • Refined source control steps to ensure reliable build operations.

Fix musl dependency 1.2.5-r8 -> r9 for alpine 3.21
Upgrade packages to align with alpine 3.21 repository
Upgrade wireguard-go to the latest commit to avoid golang.org/x/net/internal/socket: invalid reference to syscall.recvmsg message during build with go 1.23

Signed-off-by: Artur Kaufmann <[email protected]>
@frenck frenck closed this Feb 15, 2025
@frenck
Copy link
Member

frenck commented Feb 15, 2025

This is for Dependabot/renovate.

Copy link

coderabbitai bot commented Feb 15, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

The changes upgrade the base image from version 16.3.6 to 17.1.4 across both the Dockerfile and build.yaml, update several dependency versions (including git, go, iptables, and openresolv), and add the musl package. The Dockerfile now clones the master branch and checks out a specific commit for improved source control handling. The build.yaml file reflects the same base image upgrade for multiple architectures.

Changes

File Change Summary
wireguard/Dockerfile - Updated BUILD_FROM from 16.3.6 to 17.1.4
- Added apk add --no-cache musl dependency
- Updated package versions: git (2.45.3-r0→2.47.2-r0), go (1.22.10-r0→1.23.6-r0), iptables (1.8.10-r3→1.8.11-r1), openresolv (3.13.2-r0→3.13.2-r1)
- Changed git clone branch to "master" and added a git checkout for a specific commit
wireguard/build.yaml - Updated base image versions for aarch64, amd64, and armv7 from ghcr.io/hassio-addons/base:16.3.6 to ghcr.io/hassio-addons/base:17.1.4

Sequence Diagram(s)

sequenceDiagram
    participant Build as Docker Build Process
    participant Git as Git Repository
    Build->>Git: Clone repository (branch: master)
    Git-->>Build: Repository cloned
    Build->>Git: Checkout commit 12269c2761734b15625017d8565745096325392f
    Git-->>Build: Commit checked out
    Build->>Build: Continue building the image
Loading

Possibly related PRs

Suggested labels

dependencies, no-stale

Poem

I'm a rabbit with a joyful beat,
Hopping through updates, oh so neat.
Dependencies bloom like a springtime treat,
Base images rise, making builds complete.
With each commit and clone so sweet,
I celebrate in rhythm with every fleet.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between cbef0e6 and 3908e59.

📒 Files selected for processing (2)
  • wireguard/Dockerfile (2 hunks)
  • wireguard/build.yaml (1 hunks)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Arturkfmnn
Copy link
Author

This is for Dependabot/renovate.

Sorry, I don't understand. The migration should be done by Dependabot and that's why it was closed immediately?

@frenck
Copy link
Member

frenck commented Feb 15, 2025

This one isn't correct (musl shouldn't be upgraded in-place), and B is handled by bots.

../Frenck

@github-actions github-actions bot locked and limited conversation to collaborators Feb 17, 2025
@Arturkfmnn Arturkfmnn deleted the addon-base-v17-migration branch February 17, 2025 11:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants