Support Python 3.12 #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrtmm
force-pushed
the
python-3.12
branch
2 times, most recently
from
bb926ba to
9d4d9a2
Compare
fghaas
reviewed
Mar 13, 2024
| @@ -2,7 +2,7 @@ | |||
| from .__about__ import __version__ | |||
| from glob import glob | |||
| import os | |||
| import pkg_resources | |||
| import importlib_resources | |||
There was a problem hiding this comment.
We don't add any dependency on importlib_resources in this change, and we don't need to, because we do depend on tutor, which as of overhangio/tutor@d99b2fe does have that dependency.
As explained in overhangio/tutor#966 (comment), Tutor will drop that dependency once it no longer wants to support Python 3.8. At that point, this import statement will also break, and we will replace it with
from importlib import resources as importlib_resourcesPerhaps we want to add a comment to that effect now, as a benefit to our future selves?
There was a problem hiding this comment.
I see, yes, sounds like a good idea, thanks!
* Replace the use of pkg_resources (from setuptools, which is no longer included in virtual environments as of 3.12) with importlib.metadata and importlib_resources. * Add Python 3.12 to the test matrix.
fghaas
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the use of
pkg_resources(from setuptools, which is no longer included in virtual environments as of 3.12) withimportlib.metadataand importlib_resources.Add Python 3.12 to the test matrix.