Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the REPL experience #79

Open
wants to merge 19 commits into
base: main
Choose a base branch
from

Conversation

alexkalderimis
Copy link

@alexkalderimis alexkalderimis commented Feb 2, 2021

This makes the following improvements to the REPL experience:

  • CTRL_D now ends the session
  • The autocomplete menu is the native terminal-kit one, so has tab-support
  • We can autocomplete from partway through a query
  • We get error messages if we try to run an invalid query
  • We have editable history
  • History is persistent (supporting the XDG standard).

Demo: https://asciinema.org/a/fYCGz1Tv9pmcD0kbJKuKhQ0Ok

@hasura-bot
Copy link

Beep boop! 🤖

Hey @alexkalderimis, thanks for your PR!

One of my human friends will review this PR and get back to you as soon as possible.

Stay awesome! 😎

This removes most of the custom state management, replacing it with
normal promise chains, and we use the built in autocomplete system.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants