Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow object and array without type name #53

Merged
merged 4 commits into from
Dec 28, 2024

Conversation

hgiasac
Copy link
Collaborator

@hgiasac hgiasac commented Dec 28, 2024

Many object and array types don't have the type field. The tool should detect if additionalProperties or items field is not empty instead.
The PR also refactors and gets rid of redundant codes in the OpenAPI schema builder

Copy link

github-actions bot commented Dec 28, 2024

Code Coverage

Package Line Rate Health
github.com/hasura/ndc-http/connector 63%
github.com/hasura/ndc-http/connector/internal/argument 53%
github.com/hasura/ndc-http/connector/internal 57%
github.com/hasura/ndc-http/connector/internal/compression 64%
github.com/hasura/ndc-http/connector/internal/contenttype 56%
github.com/hasura/ndc-http/connector/internal/security 60%
github.com/hasura/ndc-http/ndc-http-schema/configuration 41%
github.com/hasura/ndc-http/ndc-http-schema/openapi/internal 45%
github.com/hasura/ndc-http/ndc-http-schema/openapi 40%
github.com/hasura/ndc-http/ndc-http-schema/schema 32%
github.com/hasura/ndc-http/ndc-http-schema/utils 44%
Summary 48% (4447 / 9216)

Minimum allowed line rate is 40%

@hgiasac hgiasac merged commit 1e0043f into main Dec 28, 2024
4 checks passed
@hgiasac hgiasac deleted the fix/check-additionalProperties-for-object-only branch December 28, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant