validate the latest version when new connector version is released #460
+120
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codingkarthik
had a problem deploying
to
staging
GitHub Actions
Failure
codingkarthik
had a problem deploying
to
staging
GitHub Actions
Failure
codingkarthik
had a problem deploying
to
staging
GitHub Actions
Failure
codingkarthik
had a problem deploying
to
staging
GitHub Actions
Failure
codingkarthik
had a problem deploying
to
staging
GitHub Actions
Failure
codingkarthik
had a problem deploying
to
staging
GitHub Actions
Failure
codingkarthik
had a problem deploying
to
staging
GitHub Actions
Failure
codingkarthik
had a problem deploying
to
staging
GitHub Actions
Failure
scriptnull
reviewed
Feb 10, 2025
scriptnull
reviewed
Feb 10, 2025
registry-automation/cmd/ci.go
Outdated
| @@ -245,6 +250,61 @@ func processChangedFiles(changedFiles ChangedFiles) ProcessedChangedFiles { | |||
| return result | |||
| } | |||
|
|
|||
| // validateLatestVersion checks if the latest version in metadata.json matches | |||
| // the actual latest version from the releases directory | |||
| func validateLatestVersion(connector Connector, declaredLatestVersion string) error { | |||
There was a problem hiding this comment.
The logic of this function looks good to me 👍
Could we move this function to the validate package here?
Rationale behind it:
- We introduced a new command called "validate" here.
- The validate command gets run on all commits (even before someone from Hasura adds approval to a PR) via this GitHub action. That way a connector author can get immediate feedback and fix all the validation errors even before someone from Hasura takes a look at this PR for approval.
- I see that you would like to run the validations before we go for an update in the DB etc. Could we run the validate command before invoking the
cicommand to get all the validations? (or perhaps internally invokevalidatecommand as the first thing in thecicommand) - Trying to arrive at some way where we can run the validation separately and also along with the updates.
There was a problem hiding this comment.
Yes, I will move the function to the validate package and I think it should be fine only to run the validations once every commit and not worry about running the validations with the updates.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as title