Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to TS SDK v5, support biginteger representation #35

Merged
merged 3 commits into from
May 31, 2024

Conversation

daniel-chambers
Copy link
Collaborator

This PR updates the TS SDK to v5.0.0, which brings biginteger type representation support. This is then used to annotate the BigInt scalar type.

@daniel-chambers daniel-chambers self-assigned this May 31, 2024
@daniel-chambers daniel-chambers requested a review from sordina May 31, 2024 04:38
Copy link

@sordina sordina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to get this in!

Comment on lines +11 to +12
- Updated to NDC TypeScript SDK to v5.0.0 ([#35](https://github.com/hasura/ndc-nodejs-lambda/pull/35))
- The BigInt scalar type now uses the biginteger type representation
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

representation: { type: "int64" }, // NDC doesn't have a good representation for this type as at v0.1.2, so this is the best representation in the meantime
representation: { type: "biginteger" },
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@daniel-chambers daniel-chambers merged commit ebad66f into main May 31, 2024
6 checks passed
@daniel-chambers daniel-chambers deleted the daniel/tssdk-5 branch May 31, 2024 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants