Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dotenv-cli as a dev-dependency to help run the connector with .env files, and update README instructions #36

Merged
merged 3 commits into from
Jun 6, 2024

Conversation

daniel-chambers
Copy link
Collaborator

This PR adds the dotenv-cli package to the devDependencies of the default package.json so that users can easily run the connector with a .env file (as they will in the new local dev DX) by running npx dotenv -e .env.local -- npm run watch.

It also updates the README with instructions on how to use the connector using the new local dev DX in the ddn CLI.

@daniel-chambers daniel-chambers self-assigned this Jun 6, 2024
Copy link

@sordina sordina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@@ -10,6 +10,7 @@ Changes to be included in the next upcoming release
- Added a default .gitignore that ignores node_modules in the connector template ([#34](https://github.com/hasura/ndc-nodejs-lambda/pull/34))
- Updated to NDC TypeScript SDK to v5.0.0 ([#35](https://github.com/hasura/ndc-nodejs-lambda/pull/35))
- The BigInt scalar type now uses the biginteger type representation
- Added `dotenv-cli` to the dev dependencies of the connector's default package.json to help with using .env files ([#36](https://github.com/hasura/ndc-nodejs-lambda/pull/36))
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice update!

@daniel-chambers daniel-chambers merged commit bd2b20d into main Jun 6, 2024
6 checks passed
@daniel-chambers daniel-chambers deleted the daniel/dotenv branch June 6, 2024 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants