fix: Remove dialog-polyfill

hata6502 · Apr 19, 2022 · 5d8cb8e · 5d8cb8e
1 parent fdffb4a
commit 5d8cb8e
Show file tree

Hide file tree

Showing 6 changed files with 823 additions and 562 deletions.
diff --git a/README.md b/README.md
@@ -56,22 +56,6 @@ Copied block data by `ctrl+c` are not [validated](https://editorjs.io/blockapi#m
 So copied block data and output block data may be different.
 Please see also [this comment](https://github.com/codex-team/editor.js/issues/1280#issuecomment-706482368).
 
-## &lt;dialog&gt; polyfill
-
-editorjs-layout uses `<dialog>` element and [GoogleChrome/dialog-polyfill](https://github.com/GoogleChrome/dialog-polyfill).
-Please load `dialog-polyfill.css` in your document.
-
-```html
-<head>
-  <link
-    rel="stylesheet"
-    href="https://cdn.jsdelivr.net/npm/[email protected]/dist/dialog-polyfill.css"
-    integrity="sha256-hT0ET4tfm+7MyjeBepBgV2N5tOmsAVKcTWhH82jvoaA="
-    crossorigin="anonymous"
-  />
-</head>
-```
-
 ## Build
 
 ```sh

diff --git a/docs/index.html b/docs/index.html
@@ -2,15 +2,7 @@
 <html>
   <head>
     <meta charset="utf-8" />
-
     <title>editorjs-layout</title>
-
-    <link
-      rel="stylesheet"
-      href="https://cdn.jsdelivr.net/npm/[email protected]/dist/dialog-polyfill.css"
-      integrity="sha256-hT0ET4tfm+7MyjeBepBgV2N5tOmsAVKcTWhH82jvoaA="
-      crossorigin="anonymous"
-    />
   </head>
 
   <body>
@@ -162,9 +154,8 @@
       document.querySelector("#button").addEventListener("click", async () => {
         const outputData = await editorJS.save();
 
-        document.querySelector("#output-data").textContent = JSON.stringify(
-          outputData
-        );
+        document.querySelector("#output-data").textContent =
+          JSON.stringify(outputData);
       });
 
       new EditorJS({

diff --git a/package.json b/package.json
@@ -36,7 +36,6 @@
   },
   "devDependencies": {
     "@types/uuid": "^8.3.0",
-    "dialog-polyfill": "^0.5.6",
     "ionicons": "^5.3.0",
     "license-checker": "^25.0.1",
     "prettier": "^2.2.1",

diff --git a/src/itemContent/createDialog.ts b/src/itemContent/createDialog.ts
@@ -1,5 +1,4 @@
 import type { OutputData } from "@editorjs/editorjs";
-import dialogPolyfill from "dialog-polyfill";
 import { v4 as uuidv4 } from "uuid";
 import type { LayoutBlockToolConfig } from "../LayoutBlockTool";
 
@@ -16,8 +15,6 @@ const createDialog = ({
 }) => {
   const dialog = document.createElement("dialog");
 
-  dialogPolyfill.registerDialog(dialog);
-
   dialog.style.maxWidth = "960px";
   // Make be not able to click inner
   dialog.style.padding = "0";
@@ -41,6 +38,7 @@ const createDialog = ({
       return;
     }
 
+    // @ts-expect-error
     dialog.close();
   };
 

diff --git a/src/itemContent/itemContent.ts b/src/itemContent/itemContent.ts
@@ -49,6 +49,7 @@ const renderItemContent = ({
       });
 
       document.body.append(dialog);
+      // @ts-expect-error
       dialog.showModal();
     });
   }
-Original file line number
+Diff line change
@@ Expand Up / @@ -49,6 +49,7 @@ const renderItemContent = ({ @@
           });
           document.body.append(dialog);
+          // @ts-expect-error
           dialog.showModal();
         });
       }
@@ Expand Down @@