Merge pull request #558 from hats-finance/increase-max-gov-fee

Increase max hat fee split
hats-finance · Apr 16, 2024 · 2bb59d1 · 2bb59d1
2 parents 101d71a + 952fa6d
commit 2bb59d1
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 16 deletions.
diff --git a/contracts/HATVaultsRegistry.sol b/contracts/HATVaultsRegistry.sol
@@ -52,7 +52,7 @@ contract HATVaultsRegistry is IHATVaultsRegistry, Ownable {
 
     uint16 public constant HUNDRED_PERCENT = 10000;
     // the maximum percentage of the bounty that will be converted in HATs
-    uint16 public constant MAX_HAT_SPLIT = 2000;
+    uint16 public constant MAX_HAT_SPLIT = 3500;
 
     address public hatVaultImplementation;
     address public hatClaimsManagerImplementation;

diff --git a/docs/dodoc/tge/HATAirdrop.md b/docs/dodoc/tge/HATAirdrop.md
@@ -62,7 +62,7 @@ Initialize a HATAirdrop instance
 | _root | bytes32 | new merkle tree root to use for verifying airdrop data. |
 | _startTime | uint256 | start of the redeem period and of the token lock (if exists) |
 | _deadline | uint256 | end time to redeem from the contract |
-| _lockEndTime | uint256 | end time for the token lock contract (if exists) |
+| _lockEndTime | uint256 | end time for the token lock contract. If this date is in the past, the tokens will be transferred directly to the user and no token lock will be created |
 | _periods | uint256 | number of periods of the token lock contract (if exists) |
 | _token | contract IERC20Upgradeable | the token to be airdropped |
 | _tokenLockFactory | contract ITokenLockFactory | the token lock factory to use to deploy the token locks |

diff --git a/test/hatvaults.js b/test/hatvaults.js
@@ -921,8 +921,8 @@ contract("HatVaults", (accounts) => {
         arbitrator: accounts[2],
         maxBounty: maxBounty,
         bountySplit: bountySplit,
-        bountyGovernanceHAT: 1000,
-        bountyHackerHATVested: 1001,
+        bountyGovernanceHAT: 1500,
+        bountyHackerHATVested: 2001,
         vestingDuration: 86400,
         vestingPeriods: 10
         }
@@ -1233,22 +1233,22 @@ contract("HatVaults", (accounts) => {
     }
 
     try {
-      await claimsManager.setHATBountySplit(1000, 1001);
-      assert(false, "cannot set hat bounty split to more than 2000");
+      await claimsManager.setHATBountySplit(1500, 2001);
+      assert(false, "cannot set hat bounty split to more than 3500");
     } catch (ex) {
       assertVMException(ex, "TotalHatsSplitPercentageShouldBeUpToMaxHATSplit");
     }
 
     try {
-      await claimsManager.setHATBountySplit(2001, 0);
-      assert(false, "cannot set hat bounty split to more than 2000");
+      await claimsManager.setHATBountySplit(3501, 0);
+      assert(false, "cannot set hat bounty split to more than 3500");
     } catch (ex) {
       assertVMException(ex, "TotalHatsSplitPercentageShouldBeUpToMaxHATSplit");
     }
 
     try {
-      await claimsManager.setHATBountySplit(0, 2001);
-      assert(false, "cannot set hat bounty split to more than 2000");
+      await claimsManager.setHATBountySplit(0, 3501);
+      assert(false, "cannot set hat bounty split to more than 3500");
     } catch (ex) {
       assertVMException(ex, "TotalHatsSplitPercentageShouldBeUpToMaxHATSplit");
     }
@@ -1484,22 +1484,22 @@ contract("HatVaults", (accounts) => {
     );
 
     try {
-      await hatVaultsRegistry.setDefaultHATBountySplit(2001, 0);
-      assert(false, "cannot set hat bounty split to more than 2000");
+      await hatVaultsRegistry.setDefaultHATBountySplit(3501, 0);
+      assert(false, "cannot set hat bounty split to more than 3500");
     } catch (ex) {
       assertVMException(ex, "TotalHatsSplitPercentageShouldBeUpToMaxHATSplit");
     }
 
     try {
-      await hatVaultsRegistry.setDefaultHATBountySplit(0, 2001);
-      assert(false, "cannot set hat bounty split to more than 2000");
+      await hatVaultsRegistry.setDefaultHATBountySplit(0, 3501);
+      assert(false, "cannot set hat bounty split to more than 3500");
     } catch (ex) {
       assertVMException(ex, "TotalHatsSplitPercentageShouldBeUpToMaxHATSplit");
     }
 
     try {
-      await hatVaultsRegistry.setDefaultHATBountySplit(1001, 1000);
-      assert(false, "cannot set hat bounty split to more than 2000");
+      await hatVaultsRegistry.setDefaultHATBountySplit(1501, 2000);
+      assert(false, "cannot set hat bounty split to more than 3500");
     } catch (ex) {
       assertVMException(ex, "TotalHatsSplitPercentageShouldBeUpToMaxHATSplit");
     }