check rewardDepositors amount is not too big #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orenyodfat
changed the title
jellegerbrandy
approved these changes
Jul 27, 2021
| @@ -601,6 +603,7 @@ contract HATVaults is Governable, HATMaster { | |||
| **/ | |||
| function deposit(uint256 _pid, uint256 _amount) external { | |||
| require(!poolDepositPause[_pid], "deposit paused"); | |||
| require(_amount >= MINIMUM_DEPOSIT, "amount less than 1e6"); | |||
There was a problem hiding this comment.
seems to me that if you add the check to rewardDepositors you do not need it here
There was a problem hiding this comment.
setting minimum deposit as some other advantages (e.g no need to deal with dust)
shayzluf
pushed a commit
that referenced
this pull request
Jan 16, 2022
* check the amount is not too big * MINIMUM_DEPOSIT
jellegerbrandy
added a commit
that referenced
this pull request
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.