Skip to content

Commit

Permalink
subprocess: use narrower types for TimeoutExpired.std*
Browse files Browse the repository at this point in the history
See python/cpython#97685

Thinking we'll go off of mypy_primer to decide if the union type here is
acceptable or not. I'd like us to be able to type this, since the values
being bytes can be surprising if you pass text=True
  • Loading branch information
hauntsaninja committed Oct 12, 2022
1 parent 708996d commit 90e3d38
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions stdlib/subprocess.pyi
Original file line number Diff line number Diff line change
Expand Up @@ -1828,8 +1828,8 @@ class TimeoutExpired(SubprocessError):
timeout: float
# morally: _TXT | None
output: Any
stdout: Any
stderr: Any
stdout: bytes | None
stderr: bytes | None

class CalledProcessError(SubprocessError):
returncode: int
Expand Down

0 comments on commit 90e3d38

Please sign in to comment.