Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing trade role from getTrades() API #1146

Closed
woodser opened this issue Jul 15, 2024 · 1 comment
Closed

Missing trade role from getTrades() API #1146

woodser opened this issue Jul 15, 2024 · 1 comment
Labels
a:api Related to the gRPC API

Comments

@woodser
Copy link
Contributor

woodser commented Jul 15, 2024

This issue requests returning the trade role from getTrades() API call.

Currently it's only returned for getTrade().

The solution must be tested in the haveno-ts project.
@woodser woodser added the a:api Related to the gRPC API label Jul 15, 2024
This was referenced Jul 15, 2024
Closed
Closed
woodser added a commit to woodser/haveno that referenced this issue Jul 17, 2024
@woodser
set trade role from utility class in api haveno-dex#1146
04b05c5
woodser added a commit that referenced this issue Jul 18, 2024
@woodser
set trade role from utility class in api #1146
7308206
@woodser
Copy link
Contributor Author

woodser commented Jul 18, 2024 •
edited
Loading

Fixed with #1154 and haveno-dex/haveno-ts#301

@woodser woodser closed this as completed Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
a:api Related to the gRPC API
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Apply trade role to getTrades result fa2a5qj3/haveno
1 participant
@woodser