Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix color scheme of offer book in market view [0.5 XMR] #409

Closed
erciccione opened this issue Aug 16, 2022 · 6 comments · Fixed by #443
Closed

fix color scheme of offer book in market view [0.5 XMR] #409

erciccione opened this issue Aug 16, 2022 · 6 comments · Fixed by #443
Assignees
@DomPro11
Labels
💰bounty There is a bounty on this issue good first issue Good for newcomers is:bug Something isn't working as expected P2 high priority

Comments

@erciccione
Copy link
Contributor

Screenshot_20220816_090507
@erciccione erciccione added is:bug Something isn't working as expected a:legacy UI P2 high priority labels Aug 16, 2022
@erciccione erciccione mentioned this issue Sep 6, 2022
Closed
11 tasks
@erciccione erciccione added the good first issue Good for newcomers label Sep 8, 2022
@erciccione erciccione changed the title fix color scheme of offer book in market view fix color scheme of offer book in market view [0.5 XMR] Sep 13, 2022
@erciccione erciccione added the 💰bounty There is a bounty on this issue label Sep 13, 2022
@github-actions
Copy link

There is a bounty on this issue, the amount is in the title. The reward will be awarded to the first person or group of people who resolves this issue.

If you are starting to work on this bounty, please write a comment, so that we can assign the issue to you. We expect contributors to provide a PR in a reasonable time frame or, in case of an extensive work, updates on their progresses. We will unassign the issue if we feel the assignee is not responsive or has abandoned the task.

Read the full conditions and details of our bounty system.

@aguolmedo
Copy link

hi im interested where i can find more info?

@erciccione
Copy link
Contributor Author

Hello @aguolmedo99. Feel free to ask any question. The screenshot you see is taken from the Market view (see desktop/src/main/java/bisq/desktop/main/market). As you can see the text is almost invisible, because it's white instead of black.

You are welcome to join our support room for developers on Matrix: https://matrix.to/#/#haveno-dev:haveno.network or IRC/Libera: #haveno-dev

@DomPro11
Copy link
Contributor

Hello, could I be assigned this issue? I found the problem here, and am currently drafting an official pull request. I'd be happy to explain it in detail here or on Matrix. Thanks!

@erciccione erciccione removed this from the v0.0.2 milestone Sep 18, 2022
@erciccione erciccione linked a pull request Sep 21, 2022 that will close this issue
fix color scheme of offer book in market view #443
Merged
@erciccione erciccione modified the milestone: v0.0.2 Sep 21, 2022
@erciccione
Copy link
Contributor Author

@DomPro11 DM me on matrix with an XMR address for the reward please :)

@erciccione
Copy link
Contributor Author

Reward sent. Thanks @DomPro11 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DomPro11 DomPro11

Labels
💰bounty There is a bounty on this issue good first issue Good for newcomers is:bug Something isn't working as expected P2 high priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix color scheme of offer book in market view DomPro11/haveno
3 participants
@erciccione @aguolmedo @DomPro11