fix color scheme of offer book in market view

[DomPro11]

Fixed the white on white text color in the market view when light theme is enabled by adding definitions to theme-light.css

[erciccione]

Tested ACK

Thanks @DomPro11!

[erciccione]

Actually i just hit a bug where clicking the "Market" doesn't work and the terminal throws a warning:

WARNING: Caught 'java.lang.ClassCastException' while converting value for '-fx-text-fill' from rule '*.label' in stylesheet jar:file:/home/calcifer/DEV/haveno/haveno-dex/haveno/lib/javafx-controls-15-linux.jar!/com/sun/javafx/scene/control/skin/modena/modena.bss
Sep 21, 2022 11:27:50 AM javafx.scene.CssStyleHelper calculateValue

I couldn't find the trigger, but once it happens it's impossible to navigate to the "Market" page.

[erciccione]

I keep hitting that bug where, i cannot click on the "market" tab after i left it. I deleted local files and done a clean build. Not sure what the problem is. The warning is not there anymore tough.

[DomPro11]

I discovered more details about the bug, but since it is present in the current master branch I think it should be addressed as a separate issue (which I would be happy to work on). I'm able to reliably reproduce it after cloning and clean building the master branch by clicking on my own offer in the Market View. The UI will then take me to the Buy (or Sell) tab, and switching back to the Market tab will have the program immediately switch to the Buy/Sell tab again.

Unconfirmed, but I think this has something to do with the goToOfferView() function defined in desktop/src/main/java/bisq.desktop/main/market/offerbook/OfferBookChartViewModel.java line 223. The BUY/SELL XMR buttons call this function and behave as expected (can still go back to Market View), but there's a buyTableRowSelectionListener in desktop/src/main/java/bisq.desktop/main/market/offerbook/OfferBookChartView.java which calls this function, and I don't think deactivate() is ever called which contains the removeListener() method. Again I haven't confirmed whether this is related to the cause, these are just my thoughts briefly after discovering the bug.

[erciccione]

Thanks @DomPro11 and thanks for looking the issue up! I opened #449 to keep track of the bug, this PR can move on in the meantime IMO :)