Serialize lists to comma delimited string in `PaymentAccount.toJson()` #1620

U65535F · 2025-02-27T15:35:50Z

As the title suggests, it tries to approach and fix issue 1549.
This is a newly created PR, the old PR was deleted because it was having some problems and it was not mergeable.

woodser · 2025-02-27T17:07:32Z

Getting this error testing your PR with "Can validate payment account form":

java.lang.ClassCastException: class java.util.ArrayList cannot be cast to class java.lang.String (java.util.ArrayList and java.lang.String are in module java.base of loader 'bootstrap')
	at haveno.core.payment.PaymentAccount.toForm(PaymentAccount.java:388)
	at haveno.core.api.model.PaymentAccountForm.getForm(PaymentAccountForm.java:155)
	at haveno.core.api.CorePaymentAccountsService.getPaymentAccountForm(CorePaymentAccountsService.java:112)
	at haveno.core.api.CoreApi.getPaymentAccountForm(CoreApi.java:498)
	at haveno.daemon.grpc.GrpcPaymentAccountsService.getPaymentAccountForm(GrpcPaymentAccountsService.java:135)
	at haveno.proto.grpc.PaymentAccountsGrpc$MethodHandlers.invoke(PaymentAccountsGrpc.java:769)
	at io.grpc.stub.ServerCalls$UnaryServerCallHandler$UnaryServerCallListener.onHalfClose(ServerCalls.java:182)
	at io.grpc.internal.ServerCallImpl$ServerStreamListenerImpl.halfClosed(ServerCallImpl.java:340)
	at io.grpc.internal.ServerImpl$JumpToApplicationThreadServerStreamListener$1HalfClosed.runInContext(ServerImpl.java:866)
	at io.grpc.internal.ContextRunnable.run(ContextRunnable.java:37)
	at io.grpc.internal.SerializingExecutor.run(SerializingExecutor.java:133)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)
	at java.base/java.lang.Thread.run(Thread.java:1583)
Feb 27, 2025 12:01:45 PM io.grpc.internal.SerializingExecutor run

It would be best if you're able to run the test to avoid back and forth testing.

U65535F · 2025-02-27T18:00:38Z

Getting this error testing your PR with "Can validate payment account form":

java.lang.ClassCastException: class java.util.ArrayList cannot be cast to class java.lang.String (java.util.ArrayList and java.lang.String are in module java.base of loader 'bootstrap')
	at haveno.core.payment.PaymentAccount.toForm(PaymentAccount.java:388)
	at haveno.core.api.model.PaymentAccountForm.getForm(PaymentAccountForm.java:155)
	at haveno.core.api.CorePaymentAccountsService.getPaymentAccountForm(CorePaymentAccountsService.java:112)
	at haveno.core.api.CoreApi.getPaymentAccountForm(CoreApi.java:498)
	at haveno.daemon.grpc.GrpcPaymentAccountsService.getPaymentAccountForm(GrpcPaymentAccountsService.java:135)
	at haveno.proto.grpc.PaymentAccountsGrpc$MethodHandlers.invoke(PaymentAccountsGrpc.java:769)
	at io.grpc.stub.ServerCalls$UnaryServerCallHandler$UnaryServerCallListener.onHalfClose(ServerCalls.java:182)
	at io.grpc.internal.ServerCallImpl$ServerStreamListenerImpl.halfClosed(ServerCallImpl.java:340)
	at io.grpc.internal.ServerImpl$JumpToApplicationThreadServerStreamListener$1HalfClosed.runInContext(ServerImpl.java:866)
	at io.grpc.internal.ContextRunnable.run(ContextRunnable.java:37)
	at io.grpc.internal.SerializingExecutor.run(SerializingExecutor.java:133)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)
	at java.base/java.lang.Thread.run(Thread.java:1583)
Feb 27, 2025 12:01:45 PM io.grpc.internal.SerializingExecutor run

It would be best if you're able to run the test to avoid back and forth testing.

@woodser How exactly are you able to run the tests? When I tried running make monerod1-local, it's struck and doesn't start to synchronize (the word matters here because it initializes successfully).

U65535F · 2025-02-27T18:01:32Z

A small suggestion: why don't we add tests to a workflow or create one that runs all the tests using github actions?

woodser · 2025-02-27T18:32:19Z

monerod1-local needs to be run with monerod2-local. Here are complete instructions to run a local testnet, then run API tests.

why don't we add tests to a workflow or create one that runs all the tests using github actions?

The real end-to-end tests are run as part of haveno-ts CI, but it’s based on what’s committed to haveno repo's master. Here's the last run: https://github.com/haveno-dex/haveno-ts/actions/runs/13392206971

U65535F · 2025-02-28T02:56:54Z

@woodser It's struck at this stage. It's the same on Windows. I'm currently on Linux Mint

U65535F · 2025-02-28T12:41:35Z

@woodser I have tried forking haveno-ts repo and modifying the original repo link to my fork in the Dockerfile in haveno directory. Will this be a reliable method to test the fork and its changes?
It clones from my fork in actions

U65535F · 2025-02-28T12:53:55Z

monerod1-local needs to be run with monerod2-local. Here are complete instructions to run a local testnet, then run API tests.

why don't we add tests to a workflow or create one that runs all the tests using github actions?

The real end-to-end tests are run as part of haveno-ts CI, but it’s based on what’s committed to haveno repo's master. Here's the last run: https://github.com/haveno-dex/haveno-ts/actions/runs/13392206971

I wonder why there are exceptions like Account Not Open, Incorrect Password and many in the middle of tests. Are they expected exceptions? I don't understand.

UPDATE: the workflow has failed and I cannot identify any errors (can't differentiate between errors and find their origin).

woodser · 2025-02-28T14:05:27Z

Many errors will appear as the tests are running, to test proper error handling, so that's expected.

You can run only the needed test with:

npm run test -- --baseCurrencyNetwork=XMR_LOCAL -t "Can validate payment account forms"

You should be able to confirm this test passes without any changes.

U65535F · 2025-02-28T16:37:33Z

@woodser I am not able to get the detailed log of the error in the program like this:

java.lang.ClassCastException: class java.util.ArrayList cannot be cast to class java.lang.String (java.util.ArrayList and java.lang.String are in module java.base of loader 'bootstrap')
	at haveno.core.payment.PaymentAccount.toForm(PaymentAccount.java:388)
	at haveno.core.api.model.PaymentAccountForm.getForm(PaymentAccountForm.java:155)
	at haveno.core.api.CorePaymentAccountsService.getPaymentAccountForm(CorePaymentAccountsService.java:112)
	at haveno.core.api.CoreApi.getPaymentAccountForm(CoreApi.java:498)
	at haveno.daemon.grpc.GrpcPaymentAccountsService.getPaymentAccountForm(GrpcPaymentAccountsService.java:135)
	at haveno.proto.grpc.PaymentAccountsGrpc$MethodHandlers.invoke(PaymentAccountsGrpc.java:769)
	at io.grpc.stub.ServerCalls$UnaryServerCallHandler$UnaryServerCallListener.onHalfClose(ServerCalls.java:182)
	at io.grpc.internal.ServerCallImpl$ServerStreamListenerImpl.halfClosed(ServerCallImpl.java:340)
	at io.grpc.internal.ServerImpl$JumpToApplicationThreadServerStreamListener$1HalfClosed.runInContext(ServerImpl.java:866)
	at io.grpc.internal.ContextRunnable.run(ContextRunnable.java:37)
	at io.grpc.internal.SerializingExecutor.run(SerializingExecutor.java:133)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)
	at java.base/java.lang.Thread.run(Thread.java:1583)
Feb 27, 2025 12:01:45 PM io.grpc.internal.SerializingExecutor run

@woodser All I see in the ts fork is that the test has failed, it doesn't exactly tell which part of the code failed. See

woodser · 2025-02-28T16:56:04Z

You should see the exception if you scroll up through through the logs running the tests locally.

Or using GitHub's runner, you can see the error last under Collect Docker Logs > docker-user1, from your link.

You can confirm this test will pass without any changes.

try address issue 1549

d0d8c75

U65535F requested a review from woodser as a code owner February 27, 2025 15:35

modify toJson to use a type hierarchy adapter

c0eb41a

U65535F added 4 commits February 28, 2025 20:33

revamp entire code to a better already existant version

99edd2b

use a different approach in toJson to fix failing tests

07ebfa4

remove unused hashmap import

5f45bfb

revamp toJson and use existing gsonBuilder in class

598b6cb

U65535F added 4 commits February 28, 2025 22:46

revamp toJson - 1

2c2d24a

Merge branch 'master' of https://github.com/U65535F/haveno

1f3c5af

fix horrible conflicts

b397a8e

revamp 2

c68dca2

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Serialize lists to comma delimited string in `PaymentAccount.toJson()` #1620

Serialize lists to comma delimited string in `PaymentAccount.toJson()` #1620

U65535F commented Feb 27, 2025

woodser commented Feb 27, 2025

U65535F commented Feb 27, 2025

U65535F commented Feb 27, 2025

woodser commented Feb 27, 2025

U65535F commented Feb 28, 2025 •

edited

Loading

U65535F commented Feb 28, 2025 •

edited

Loading

U65535F commented Feb 28, 2025 •

edited

Loading

woodser commented Feb 28, 2025

U65535F commented Feb 28, 2025 •

edited

Loading

woodser commented Feb 28, 2025 •

edited

Loading

Serialize lists to comma delimited string in PaymentAccount.toJson() #1620

Are you sure you want to change the base?

Serialize lists to comma delimited string in PaymentAccount.toJson() #1620

Conversation

U65535F commented Feb 27, 2025

woodser commented Feb 27, 2025

U65535F commented Feb 27, 2025

U65535F commented Feb 27, 2025

woodser commented Feb 27, 2025

U65535F commented Feb 28, 2025 • edited Loading

U65535F commented Feb 28, 2025 • edited Loading

U65535F commented Feb 28, 2025 • edited Loading

woodser commented Feb 28, 2025

U65535F commented Feb 28, 2025 • edited Loading

woodser commented Feb 28, 2025 • edited Loading

Serialize lists to comma delimited string in `PaymentAccount.toJson()` #1620

Serialize lists to comma delimited string in `PaymentAccount.toJson()` #1620

U65535F commented Feb 28, 2025 •

edited

Loading

U65535F commented Feb 28, 2025 •

edited

Loading

U65535F commented Feb 28, 2025 •

edited

Loading

U65535F commented Feb 28, 2025 •

edited

Loading

woodser commented Feb 28, 2025 •

edited

Loading