Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit tests #6

Open
2 of 3 tasks
plfiorini opened this issue Jul 17, 2015 · 0 comments
Open
2 of 3 tasks

Unit tests #6

plfiorini opened this issue Jul 17, 2015 · 0 comments
Labels
feature
Milestone
0.7.0

Comments

@plfiorini
Copy link
Member

Flesh out unit tests for the API.

  • Test AccountsManager
  • Test UserAccount
  • Test QML

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.
@plfiorini plfiorini modified the milestones: Version 0.6.0, Version 0.7.0, Version 0.8.0 Jul 17, 2015
@plfiorini plfiorini modified the milestones: Version 0.7.0, Version 0.8.0 Jul 29, 2015
plfiorini added a commit that referenced this issue Jul 30, 2015
@plfiorini
Add QDBusConnection argument to AccountsManager
0207e91 
With unit tests we want to fake an AccountsService daemon but of
course we cannot register with the system bus.

Adding a QDBusConnection argument to the constructor (that
defaults to the system bus) allows us to pass a session bus
for unit tests.

Issue: #6
plfiorini added a commit that referenced this issue Jul 30, 2015
@plfiorini
Initial unit test
b4d9071 
Issue: #6
plfiorini added a commit that referenced this issue Jul 30, 2015
@plfiorini
Do not test deleteUser twice
4369cd0 
Issue: #6
plfiorini added a commit that referenced this issue Jul 31, 2015
@plfiorini
More tests
4442ca3 
Test user caching and find.

Issue: #6
plfiorini added a commit that referenced this issue Jul 31, 2015
@plfiorini
Add FakeUser
13b8e4d 
Issue: #6
plfiorini added a commit that referenced this issue Jul 31, 2015
@plfiorini
Remove annoying debug messages from FakeAccounts
3a5544d 
Issue: #6
plfiorini added a commit that referenced this issue Jul 31, 2015
@plfiorini
Use the same bus for UserAccount as AccountsManager
27791f1 
For unit tests we need to use the session bus rather than the
system bus. Make UserAccount use the same connection as AccountsManager.

Issue: #6
plfiorini added a commit that referenced this issue Jul 31, 2015
@plfiorini
Avoid potential crashes during tests
5f6447e 
Issue: #6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
0.7.0
Development

No branches or pull requests
1 participant
@plfiorini