feat(cordyceps): added new push_back and pop_front methods to list #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hawkw
reviewed
Jun 5, 2022
There was a problem hiding this comment.
thanks for the PR! i have a couple of very minor suggestions:
- the RustDoc for the
Listtype references using the list as a FIFO usingpush_frontandpop_back, it would be nice to add something saying that it can also be used as a stack or double-ended queue using these methods - thanks for adding tests! it could be good to add these methods to the
proptestfuzz_linked_listtest as well, but if that's too much work, it would be fine to do that in a follow-up branch.
thanks again for the PR!
…test. updated documentation to clarify the List can now be used as a stack or Doubly-Linked List
Edit: Committed these changes on my other account but it's still me! |
hawkw
approved these changes
Jun 5, 2022
hawkw
approved these changes
Jun 5, 2022
|
oh, looks like mind fixing that? thanks! |
auto-merge was automatically disabled
June 5, 2022 22:21
Head branch was pushed to by a user without write access
|
Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some nice-to-have methods as detailed in this issue.
Changes:
push_backmethodpop_frontmethodSmall change but hope it's good :D