-
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Swap out lazy_static for once_cell #72
base: main
Are you sure you want to change the base?
Conversation
It looks like CI is stuck on this PR --- not totally sure what's going on there. |
Should we report this to GitHub? This seems like it's permanently stuck. |
Looks like that was my fault; I changed the CI configuration, and it should run correctly now. |
@james7132 are you still intending to finish this (fix the two CI failures)? |
Looks like |
@hawkw ping about this question |
@james7132 maybe just update the PR to get it to go green, since this would be a trivial change? Then there's a chance no further back and forth is needed when Eliza finds some time for this again. |
With |
Also bumped the edition to 2021. |
Loom seems to dislike |
Seems like parts of |
Now that OnceLock is stable another possibility would be to use it instead but keep lazy_static as an optional feature for older compiler support |
Although you probably don't want to increase the MSRV that much for now, |
Any progress on this PR? I'm trying to purge |
This would be nice. Could be a default Cargo feature |
Fixes #71. Another benefit is that accessing registry's next counter doesn't require an extra lazy check, only on the actual freelist.