-
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
thingbuf
can't compile on macos
#54
Comments
hawkw
added a commit
that referenced
this issue
Mar 16, 2022
This fixes a compilation error that occurs on macOS due to `std::thread::Thread` not being `UnwindSafe` on that platform. It's kind of sad that we have to do this, but I think it's probably fine. Fixes #54 Signed-off-by: Eliza Weisman <[email protected]>
PR #53 should fix this. I also added a macOS CI run, but unfortunately, I can't actually confirm that it fixes the compilation error because GitHub Actions is down :/ |
hawkw
added a commit
that referenced
this issue
Mar 16, 2022
This fixes a compilation error that occurs on macOS due to `std::thread::Thread` not being `UnwindSafe` on that platform. It's kind of sad that we have to do this, but I think it's probably fine. Fixes #54 Signed-off-by: Eliza Weisman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I think this is definitely a problem with the
std
implementation, so i asked in the zulip lib channel, but there is probably a way around this withAssertUnwindSafe
:The text was updated successfully, but these errors were encountered: