-
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
crate does not compile as no_std #58
Comments
Sorry, my bad; I was checking no-std support manually rather than on CI, which, as we all know, was definitely a mistake. Should have a new release that builds with |
hawkw
added a commit
that referenced
this issue
Apr 11, 2022
This fixes compilation for no-std targets. My bad --- I was checking this manually and never added a CI job for it. This branch adds a CI check that the crate compiles with `--no-default-features`, and fixes a number of issues that broke the no-std build: * f8d9527 fix(no_std): fix warning in `resume_unwind` * cbf943a fix(no_std): fix compilation error in `unreachable_unchecked` * 8ae178a fix(no_std): remove use of `thread::panicking` * dab0d49 fix(alloc): fix missing `Box` imports * 208defc fix(no_std): wrong feature gate for println macros Fixes #58 Signed-off-by: Eliza Weisman <[email protected]>
hawkw
added a commit
that referenced
this issue
Apr 12, 2022
Version 0.1.2 should fix this, sorry for any inconvenience! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Results in:
At a glance:
println
s gated behindif cfg!(test) || cfg!(all(thingbuf_trace, feature = "std"))
instead of#[cfg(any(test, all(thingbuf_trace, feature = "std")))]
.Core::close
referencesstd::thread::panicking()
Box
is used without being imported fromalloc::boxed::Box
.The text was updated successfully, but these errors were encountered: