Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add test for mpsc::try_recv_ref, enable some loom tests #63

Merged
merged 1 commit into from
May 13, 2022
Merged

chore: add test for mpsc::try_recv_ref, enable some loom tests #63

merged 1 commit into from
May 13, 2022

Conversation

name1e5s
Copy link
Contributor

@name1e5s name1e5s commented May 13, 2022 •
edited
Loading

  • add a simple test for try_recv_ref
  • changes mpsc_sync in loom.yml to mpsc_blocking , make CI works
  • also enable some tests blocked by tokio-rs/loom#246

@hawkw
Copy link
Owner

hawkw commented May 13, 2022 •
edited
Loading

Unfortunately loom has not yet published the change that unblocks some of the blocking MPSC tests, so I think we are still waiting for v0.5.5 to re-enable those...

Edit: Oh, never mind, I forgot we had a git patch for now.

hawkw
hawkw approved these changes May 13, 2022
View reviewed changes
Copy link
Owner

@hawkw hawkw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, this looks good to me!

@hawkw hawkw merged commit 6728acd into hawkw:main May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawkw hawkw hawkw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@name1e5s @hawkw