Skip to content

Commit

Permalink
Possible bug fix for thread comment status
Browse files Browse the repository at this point in the history
As pointed out in google#22, the status for every comment seems to be fyi.
This seems to fix that.
  • Loading branch information
Harry Lawrence committed Dec 23, 2015
1 parent d2213d9 commit 2a2f054
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions commands/output/output.go
Original file line number Diff line number Diff line change
Expand Up @@ -119,15 +119,16 @@ func showThread(r *review.Review, thread review.CommentThread) error {

// showSubThread prints the given comment (sub)thread, indented by the given prefix string.
func showSubThread(r *review.Review, thread review.CommentThread, indent string) error {
comment := thread.Comment
statusString := "fyi"
if thread.Resolved != nil {
if *thread.Resolved {
if comment.Resolved != nil {
if *comment.Resolved {
statusString = "lgtm"
} else {
statusString = "needs work"
}
}
comment := thread.Comment

threadHash, err := comment.Hash()
if err != nil {
return err
Expand Down

0 comments on commit 2a2f054

Please sign in to comment.