When RHEL publish fails, log reason (test_results)
#845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nishaatr
requested changes
Jan 6, 2025
nishaatr
approved these changes
Jan 6, 2025
|
@ldziedziul are you able to review, please? |
ldziedziul
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While investigating an action failure of an
RHELpublish failure, the logs indicated that the image had never published, but not why.The publish response includes a link to an
test_resultsresult which can provide more information.Updated the script to log these results in the case of failure.
I've gone backwards and forwards on the implementation - ideally the publish request should be polled rather than the the presence of an image, but would require significant refactoring of the script which is difficult to test due to its destructive nature.
In fact, in isolation this change is pointless - we build from tags so the usage of this change will only gradually increase. But it helps to document how we get investigate subsequent failures. Ideally once next investigated, the root cause can be identified and resolved.