Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include TS typings into client artifact #537

Closed
puzpuzpuz opened this issue Jun 9, 2020 · 0 comments · Fixed by #568
Closed

Include TS typings into client artifact #537

puzpuzpuz opened this issue Jun 9, 2020 · 0 comments · Fixed by #568
Labels
Contribution-Welcome Estimation: S good first issue Priority: High Type: Defect
Milestone
4.0

Comments

@puzpuzpuz
Copy link
Contributor

At the moment the artifacts lacks some typings (say, for long library), so TS compiler reports errors when the client is used in a TS-based app. We should fix that.

Reported by @aigoncharov
@puzpuzpuz puzpuzpuz added this to the 4.0 milestone Jun 9, 2020
@puzpuzpuz puzpuzpuz mentioned this issue Aug 10, 2020
Merged
puzpuzpuz added a commit that referenced this issue Aug 14, 2020
@puzpuzpuz
Separate internal APIs from public ones (#568)
c7d063a 
Includes the following:
* Marks internal modules and class members with @internal tag which is supported by both tsc and typedoc
* Fixes typedoc flags, so that it now ignores internal stuff
* Excludes internal modules and members from tsc output
* Excludes source maps from tsc output
* Moves typings for long and bluebird into non-dev dependencies, as TS users need them (see #537)
* Adds test for declarations produced by tsc
* Also includes some code improvements, like reformatting, interface extraction, etc.
harunalpak pushed a commit to harunalpak/hazelcast-nodejs-client that referenced this issue Dec 8, 2022
@puzpuzpuz
Separate internal APIs from public ones (hazelcast#568)
c7a804c 
Includes the following:
* Marks internal modules and class members with @internal tag which is supported by both tsc and typedoc
* Fixes typedoc flags, so that it now ignores internal stuff
* Excludes internal modules and members from tsc output
* Excludes source maps from tsc output
* Moves typings for long and bluebird into non-dev dependencies, as TS users need them (see hazelcast#537)
* Adds test for declarations produced by tsc
* Also includes some code improvements, like reformatting, interface extraction, etc.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Contribution-Welcome Estimation: S good first issue Priority: High Type: Defect
Projects
None yet
Milestone
4.0
Development

Successfully merging a pull request may close this issue.

Separate internal APIs from public ones puzpuzpuz/hazelcast-nodejs-client
2 participants
@burakcelebi @puzpuzpuz