Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use latest versions of python and jupyter-book #461

Merged
merged 37 commits into from
Jan 9, 2023

Conversation

PhiSpel
Copy link
Collaborator

@PhiSpel PhiSpel commented Nov 23, 2022

Description

closes #460
like #458 but with cards instead of grid-item-card

Checklist

  • This pull request is associated to an issue
  • Add someone else as reviewer and wait for approval before merging.

@PhiSpel
Copy link
Collaborator Author

PhiSpel commented Nov 23, 2022

Now, it looks better, see here.

Only remaining issue is that the CSS variable --sd-color-card-header needs to be changed to #00000008 instead of transparent, see here. I just need to find the right file to put this information...

...I may be able to set class-header

@PhiSpel PhiSpel changed the title 460 ps/latest versions use latest versions of python and jupyter-book Nov 25, 2022
@PhiSpel
Copy link
Collaborator Author

PhiSpel commented Nov 26, 2022

running the "live code" function does not work, as the kernel seems to run on python instead of octave (it does work correctly in mybinder). This is different, for example, in #438

@PhiSpel PhiSpel closed this Nov 26, 2022
@PhiSpel PhiSpel reopened this Nov 26, 2022
@PhiSpel
Copy link
Collaborator Author

PhiSpel commented Dec 21, 2022

@Florian314 what do you think about the layout, for example here?

@PhiSpel PhiSpel requested a review from Florian314 December 21, 2022 16:33
@PhiSpel
Copy link
Collaborator Author

PhiSpel commented Dec 24, 2022

Usually, one should be able to define custom styles in a _static/custom.css file within the project directory. I am afraid this is not accessed by jupyter book, see e9abf86

These colors are accessible by the :header-style: keyword, of which bg-light seems to be the most sensible.

So, @Florian314, please look at the layout of the cards in "Das Stauproblem - Motivation zur Benutzung dieses Buches" and "Verwendung dieses Buches". What's your opinion on them?

When I have the feedback, I can adapt the 40-some other files.

@PhiSpel PhiSpel self-assigned this Dec 27, 2022
@Florian314
Copy link
Collaborator

image
The box in a box looks strange to me

@Florian314
Copy link
Collaborator

image
This looks the best if you can delet the line below "Voraussetzungen"

@PhiSpel
Copy link
Collaborator Author

PhiSpel commented Jan 9, 2023

Actually, I just realized, that the boxes are now the same as the old ones:

image

@Florian314 Isn't this just fine / even better?

@Florian314
Copy link
Collaborator

yeah, i personely like the old ones the most

@PhiSpel PhiSpel merged commit 084f6bd into master Jan 9, 2023
@PhiSpel PhiSpel deleted the 460-ps/latest_versions branch January 9, 2023 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

use the latest python and jupyter-notebook releases
3 participants