Chunter: user status (#1608) #1692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: budaeva <[email protected]>
Signed-off-by: budaeva <[email protected]>
BykhovDenis
requested changes
May 6, 2022
models/contact/src/index.ts
Outdated
| @@ -38,6 +39,7 @@ import contact from './plugin' | |||
|
|
|||
| export const DOMAIN_CONTACT = 'contact' as Domain | |||
| export const DOMAIN_CHANNEL = 'channel' as Domain | |||
| export const DOMAIN_STATUS = 'status' as Domain | |||
There was a problem hiding this comment.
We really need new domain for it?
| client.createDoc(contact.class.Status, space, { | ||
| attachedTo: employeeId, | ||
| attachedToClass: contact.class.Employee, | ||
| collection: 'statuses', |
There was a problem hiding this comment.
Please add this collection to employee interface
|
|
||
| $: today = new Date(Date.now()) | ||
| $: dueDateMs = statusDueDate | ||
| $: isOverdue = dueDateMs !== undefined && dueDateMs !== null && dueDateMs < today.getTime() |
|
|
||
| export let statusDueDate: Timestamp | undefined | ||
|
|
||
| $: today = new Date(Date.now()) |
There was a problem hiding this comment.
Why we need this? Please look packages/ui/Timesince for example
| @@ -29,3 +29,14 @@ export async function getChannelProviders (): Promise<Map<Ref<ChannelProvider>, | |||
| } | |||
| return map | |||
| } | |||
|
|
|||
| export function formatDate (dueDateMs: Timestamp | undefined): string { | |||
There was a problem hiding this comment.
It should only format timestamp, undefined should be handled before call
|
|
||
| export function formatDate (dueDateMs: Timestamp | undefined): string { | ||
| return dueDateMs === undefined || dueDateMs === null | ||
| ? 'no exp' |
There was a problem hiding this comment.
It should be IntlString I think
| checkOverdue() | ||
| }) | ||
|
|
||
| async function checkOverdue () { |
Signed-off-by: budaeva <[email protected]>
Signed-off-by: budaeva <[email protected]>
Signed-off-by: budaeva <[email protected]>
Signed-off-by: budaeva <[email protected]>
BykhovDenis
approved these changes
May 12, 2022
Signed-off-by: budaeva <[email protected]>
Signed-off-by: budaeva <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: budaeva [email protected]
closes #1608