Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UBERF-6037 Enhance codeblock extension #4993

Merged
merged 1 commit into from
Mar 17, 2024
Merged

UBERF-6037 Enhance codeblock extension #4993

merged 1 commit into from
Mar 17, 2024

Conversation

aonnikov
Copy link
Member

@aonnikov aonnikov commented Mar 15, 2024

Contribution checklist

Brief description

Screen.Recording.2024-03-15.at.22.26.04.mov

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does a local formatting is applied (rush format)
  • - Does a local svelte-check is applied (rush svelte-check)
  • - Does a local UI tests are executed UI Testing
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

A list of closed updated issues

Contributor requirements

  • - Sign-off is provided. DCO
  • - GPG Signature is provided. GPG

View in Huly UBERF-6047

@aonnikov aonnikov requested review from haiodo and BykhovDenis March 15, 2024 15:29
@aonnikov aonnikov force-pushed the uberf-6037-codeblock branch from 2c18ecb to 08f60c8 Compare March 15, 2024 16:16
@aonnikov aonnikov force-pushed the uberf-6037-codeblock branch from 08f60c8 to 41841c1 Compare March 15, 2024 16:46
@haiodo haiodo merged commit e587118 into main Mar 17, 2024
7 checks passed
@haiodo haiodo deleted the uberf-6037-codeblock branch March 17, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants