org_llvm_openmp: Add omp-tools.h to bundled.BUILD.bazel #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pawel Czarnecki <[email protected]>
|
/gcbrun |
|
Thanks for contributing! |
|
No problem @QuantamHD, I'm glad that I could help with that :) This problem is in fact one of the blockers for google/xls#975 (as well as #164 and #165). It looks like build and test in CI have passed. Please let me know if this is OK to merge or if anything needs to be changed here. |
QuantamHD
approved these changes
May 25, 2023
|
No changes needed thanks again.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes
org_llvm_openmpbuild failures I encountered while trying to run target based on ruleplace_and_route.BUILDfile foropenmpdidn't specifyomp-tools.has its dependency. This header is present in the codebase asomp-tools.h.varand it is renamed to requiredomp-tools.hby the cmake flow. In order to fix this in bazel rules I addedgenrulefor copying the file and specified the missing dependency.