-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor housekeeping updates #1246
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #1246 +/- ##
==========================================
+ Coverage 91.56% 91.63% +0.07%
==========================================
Files 42 42
Lines 9552 9550 -2
Branches 1928 1920 -8
==========================================
+ Hits 8746 8751 +5
+ Misses 523 521 -2
+ Partials 283 278 -5 ☔ View full report in Codecov by Sentry. |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
@rly overall this looks good. There are coverage gaps. If you are okay with that, then I will approve. |
Looking closely at the coverage report, I see that all the lines that now lack coverage had previously lacked coverage. We can add the missing tests in a separate PR, but I think that should not need to block this one. |
Motivation
requirements-min.txt
in favor of an optional dependency group inpyproject.toml
and update docs accordinglypyproject.toml
license
key to correct formatHow to test the behavior?
Checklist
CHANGELOG.md
with your changes?