downgrade urllib3 to 1.24.3 #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #77 +/- ##
=======================================
Coverage 66.68% 66.68%
=======================================
Files 24 24
Lines 4749 4749
Branches 1075 1075
=======================================
Hits 3167 3167
Misses 1216 1216
Partials 366 366Continue to review full report at Codecov.
|
bendichter
approved these changes
May 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use urllib3 1.24.3 instead of 1.25.
Motivation
See NeurodataWithoutBorders/pynwb#921. There was a dependency conflict between urllib3 and requests. This downgrades urllib3 to 1.24.3 (which includes a security fix that was initially added to 1.25).